Conversation
|
I think everything should be there but please do let me know if I'm missing anything |
|
Hey @maxday , any chance of getting this merged? Appreciate this is a spare time/voluntary project, so no worries if you're super busy, thought it might have just gotten lost in the noise. |
|
thanks a lot @SamuelCox will have a look at it this week-end aiming to merge this before next Monday! |
|
Thanks @SamuelCox By removing the line I commented on your PR, it builds successfully, WDYT? If you agree, can you update the PR so I can merge? Or I can add a commit on top of your PR, let me know! Thanks for your contribution! |
| <PackageReference Include="Amazon.Lambda.RuntimeSupport" Version="1.14.1" /> | ||
| <PackageReference Include="Amazon.Lambda.Core" Version="2.8.0" /> | ||
| <PackageReference Include="Amazon.Lambda.Serialization.SystemTextJson" Version="2.4.4" /> | ||
| <PackageReference Include="Microsoft.DotNet.ILCompiler" Version="10.0.1" /> |
| <PackageReference Include="Amazon.Lambda.Core" Version="2.8.0" /> | ||
| <PackageReference Include="Amazon.Lambda.Serialization.SystemTextJson" Version="2.4.4" /> | ||
| <PackageReference Include="Microsoft.DotNet.ILCompiler" Version="10.0.1" /> | ||
| <PackageReference Include="Microsoft.NET.ILLink.Tasks" Version="10.0.1" /> |
There was a problem hiding this comment.
nit: the indentation is missing here
|
Will update later today, thanks! |
Pull Request Checklist
For New Runtime Additions
README.mdto reflect the new runtimebuild.sh.github/dependabot.yml.gitignoreDescription
Add support for dotnet10 and dotnet10 aot.
https://aws.amazon.com/blogs/compute/net-10-runtime-now-available-in-aws-lambda/
This one is probably particularly interesting since there is a known performance problem for Lambda until Microsoft releases a patch.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.